chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/most_visited_handler.cc ('k') | chrome/browser/ui/webui/options/core_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc b/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

index d91253dec6af569f228701c36f6e32d8a95e8080..c7dfd1782e31c71aa74c735b33300e99592b3960 100644

--- a/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

+++ b/chrome/browser/ui/webui/options/chromeos/system_settings_provider.cc

@@ -201,8 +201,7 @@ void SystemSettingsProvider::DoSet(const std::string& path, Value* in_value) {

if (path == kSystemTimezone) {

string16 value;

- if (!in_value || !in_value->IsType(Value::TYPE_STRING) ||

- !in_value->GetAsString(&value))

+ if (!in_value || !in_value->IsString() || !in_value->GetAsString(&value))

return;

const icu::TimeZone* timezone = GetTimezone(value);

if (!timezone)

« no previous file with comments | « chrome/browser/ui/webui/ntp/most_visited_handler.cc ('k') | chrome/browser/ui/webui/options/core_options_handler.cc » ('j') | no next file with comments »