chrome/browser/policy/configuration_policy_provider_win_unittest.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_provider_win_unittest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/configuration_policy_provider_mac_unittest.cc ('k') | chrome/browser/prefs/pref_model_associator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/configuration_policy_provider_win_unittest.cc

diff --git a/chrome/browser/policy/configuration_policy_provider_win_unittest.cc b/chrome/browser/policy/configuration_policy_provider_win_unittest.cc

index 433891ac27fc7380b7c6a0cdf1c76578affaac80..ef893844e3cf1eb17e0b538082d4817158e0658e 100644

--- a/chrome/browser/policy/configuration_policy_provider_win_unittest.cc

+++ b/chrome/browser/policy/configuration_policy_provider_win_unittest.cc

@@ -272,7 +272,7 @@ void ConfigurationPolicyProviderWinTest::WriteValue(HKEY hive,

int index = 1;

for (ListValue::const_iterator element(list->begin());

element != list->end(); ++element) {

- ASSERT_TRUE((*element)->IsType(Value::TYPE_STRING));

+ ASSERT_TRUE((*element)->IsString());

std::string element_value;

ASSERT_TRUE((*element)->GetAsString(&element_value));

key.WriteValue(base::IntToString16(index++).c_str(),

@@ -289,7 +289,7 @@ void ConfigurationPolicyProviderWinTest::WriteValue(HKEY hive,

void ConfigurationPolicyProviderWinTest::WriteInvalidValue(HKEY hive,

const char* name,

const Value* value) {

- if (value->IsType(Value::TYPE_STRING))

+ if (value->IsString())

WriteDWORD(hive, name, -1);

else

WriteString(hive, name, L"bad value");