chrome/browser/extensions/external_pref_extension_loader.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_pref_extension_loader.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_pref_extension_loader.cc

diff --git a/chrome/browser/extensions/external_pref_extension_loader.cc b/chrome/browser/extensions/external_pref_extension_loader.cc

index 8d90ee7249c19adf2ae7bd746cc885ed8504427d..7bab891e1b4e9c6d3de74232c133b6bc61de5564 100644

--- a/chrome/browser/extensions/external_pref_extension_loader.cc

+++ b/chrome/browser/extensions/external_pref_extension_loader.cc

@@ -22,7 +22,7 @@ DictionaryValue* ExtractPrefs(const FilePath& path,

LOG(WARNING) << "Unable to deserialize json data: " << error_msg

<< " In file " << path.value() << " .";

} else {

- if (!extensions->IsType(Value::TYPE_DICTIONARY)) {

+ if (!extensions->IsDictionary()) {

LOG(WARNING) << "Expected a JSON dictionary in file "

<< path.value() << " .";

} else {