chrome/browser/extensions/extension_webrequest_api_unittest.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webrequest_api_unittest.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webrequest_api_unittest.cc

diff --git a/chrome/browser/extensions/extension_webrequest_api_unittest.cc b/chrome/browser/extensions/extension_webrequest_api_unittest.cc

index 8398433af1a7584333a1892b82f555d137d610e8..81e7b7e048df9a0a6bb88ddbce349065db9af91a 100644

--- a/chrome/browser/extensions/extension_webrequest_api_unittest.cc

+++ b/chrome/browser/extensions/extension_webrequest_api_unittest.cc

@@ -477,8 +477,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {

scoped_ptr<Value> event_arg_value(

JSONStringValueSerializer(event_arg_string).Deserialize(NULL, NULL));

- ASSERT_TRUE(event_arg_value.get() &&

- event_arg_value->IsType(Value::TYPE_LIST));

+ ASSERT_TRUE(event_arg_value.get() && event_arg_value->IsList());

DictionaryValue* event_arg_dict = NULL;

ASSERT_TRUE(