chrome/browser/extensions/extension_management_api.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_api.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_management_api.cc

diff --git a/chrome/browser/extensions/extension_management_api.cc b/chrome/browser/extensions/extension_management_api.cc

index e69a626202ea6a724acecd972e4fd4155e48ea31..a53ed30f14fdddc08b272b38bd2a259ce6a8335d 100644

--- a/chrome/browser/extensions/extension_management_api.cc

+++ b/chrome/browser/extensions/extension_management_api.cc

@@ -227,7 +227,7 @@ class SafeManifestJSONParser : public UtilityProcessHost::Client {

CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

Value* value = NULL;

CHECK(wrapper.Get(0, &value));

- if (value->IsType(Value::TYPE_DICTIONARY))

+ if (value->IsDictionary())

parsed_manifest_.reset(static_cast<DictionaryValue*>(value)->DeepCopy());

else

error_ = kManifestParseError;