chrome/browser/extensions/extension_function.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function.cc

diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc

index 0374dd06a0a9d1f6c47d7d17835f03d373d3528d..939c6aa7795b1a17c75802479e9f4aa8f1750c41 100644

--- a/chrome/browser/extensions/extension_function.cc

+++ b/chrome/browser/extensions/extension_function.cc

@@ -86,7 +86,7 @@ void ExtensionFunction::Run() {

bool ExtensionFunction::HasOptionalArgument(size_t index) {

Value* value;

- return args_->Get(index, &value) && !value->IsType(Value::TYPE_NULL);

+ return args_->Get(index, &value) && !value->IsNull();

}

void ExtensionFunction::SendResponseImpl(base::ProcessHandle process,