chrome/browser/extensions/extension_cookies_api.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_cookies_api.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_cookies_api.cc

diff --git a/chrome/browser/extensions/extension_cookies_api.cc b/chrome/browser/extensions/extension_cookies_api.cc

index f9f7e51dfee5e32b3c9f3641c12360f4c0667dd0..303be0972d7e151dfe109de9fd73ea11965d5d7b 100644

--- a/chrome/browser/extensions/extension_cookies_api.cc

+++ b/chrome/browser/extensions/extension_cookies_api.cc

@@ -346,7 +346,7 @@ bool SetCookieFunction::RunImpl() {

EXTENSION_FUNCTION_VALIDATE(details->Get(keys::kExpirationDateKey,

&expiration_date_value));

double expiration_date;

- if (expiration_date_value->IsType(Value::TYPE_INTEGER)) {

+ if (expiration_date_value->IsInteger()) {

int expiration_date_int;

EXTENSION_FUNCTION_VALIDATE(

expiration_date_value->GetAsInteger(&expiration_date_int));