chrome/browser/debugger/devtools_remote_service.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/devtools_remote_service.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/debugger/devtools_remote_service.cc

diff --git a/chrome/browser/debugger/devtools_remote_service.cc b/chrome/browser/debugger/devtools_remote_service.cc

index 329e1a8b0cb9a6f9b800bf8344e041bc18e147a4..5868f474413ad29985c26691d2015ba170741170 100644

--- a/chrome/browser/debugger/devtools_remote_service.cc

+++ b/chrome/browser/debugger/devtools_remote_service.cc

@@ -46,7 +46,7 @@ void DevToolsRemoteService::HandleMessage(

return;

}

DictionaryValue* json;

- if (request->IsType(Value::TYPE_DICTIONARY)) {

+ if (request->IsDictionary()) {

json = static_cast<DictionaryValue*>(request.get());

if (!json->HasKey(kCommandKey)) {

NOTREACHED(); // Broken protocol - no "command" specified