chrome/browser/component_updater/component_unpacker.cc - Issue 7661009: base: Add Is* functions to Value class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_unpacker.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tony review Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/component_updater/component_unpacker.cc

diff --git a/chrome/browser/component_updater/component_unpacker.cc b/chrome/browser/component_updater/component_unpacker.cc

index 8453df25e9f6224e4871610e8b82a3f211daa2a6..c148831afb6c8ed00b251a56192e12e0856564de 100644

--- a/chrome/browser/component_updater/component_unpacker.cc

+++ b/chrome/browser/component_updater/component_unpacker.cc

@@ -129,7 +129,7 @@ base::DictionaryValue* ReadManifest(const FilePath& unpack_path) {

scoped_ptr<base::Value> root(serializer.Deserialize(NULL, &error));

if (!root.get())

return NULL;

- if (!root->IsType(base::Value::TYPE_DICTIONARY))

+ if (!root->IsDictionary())

return NULL;

return static_cast<base::DictionaryValue*>(root.release());

}