base: Add Is* functions to Value class.

chrome/browser/prefs/pref_model_associator.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_model_associator.h"
 
 #include "base/auto_reset.h"
 #include "base/json/json_reader.h"
 #include "base/logging.h"
 #include "base/tracked.h"
@@ skipping 54 matching lines @@
                  << reader.GetErrorMessage();
       return;
     }
 
     // Merge the server value of this preference with the local value.
     scoped_ptr<Value> new_value(MergePreference(*pref, *value));
 
     // Update the local preference based on what we got from the
     // sync server. Note: this only updates the user value store, which is
     // ignored if the preference is policy controlled.
-    if (new_value->IsType(Value::TYPE_NULL)) {
+    if (new_value->IsNull()) {
       pref_service_->ClearPref(pref_name.c_str());
-    } else if (!new_value->IsType(pref->GetType())) {
+    } else if (new_value->GetType() != pref->GetType()) {
       LOG(WARNING) << "Synced value for " << preference.name()
                    << " is of type " << new_value->GetType()
                    << " which doesn't match pref type " << pref->GetType();
     } else if (!pref->GetValue()->Equals(new_value.get())) {
       pref_service_->Set(pref_name.c_str(), *new_value);
     }
 
     SendUpdateNotificationsIfNecessary(pref_name);
 
     // If the merge resulted in an updated value, inform the syncer.
@@ skipping 353 matching lines @@
       return;
     }
     changes.push_back(SyncChange(SyncChange::ACTION_UPDATE, sync_data));
   }
 
   SyncError error =
       sync_processor_->ProcessSyncChanges(FROM_HERE, changes);
   if (error.IsSet())
     StopSyncing(PREFERENCES);
 }