Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 766083002: OOP PDF: Use an object element for print preview instead of an embed. (Closed)

Created:
6 years ago by Sam McNally
Modified:
6 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv+watch_chromium.org, raymes, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Use an object element for print preview instead of an embed. This avoids the origin checking that prevents the PDF extension from embedding the print-preview PDFs, which are served from the chrome scheme. BUG=437417 Committed: https://crrev.com/0a182576926c2b560035db3d53abd614a1423145 Cr-Commit-Position: refs/heads/master@{#306307}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam McNally
6 years ago (2014-12-01 00:09:59 UTC) #4
Lei Zhang
lgtm since this is just a revert to the previous behavior for the print preview ...
6 years ago (2014-12-01 23:38:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766083002/40001
6 years ago (2014-12-01 23:39:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years ago (2014-12-02 00:32:34 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-02 00:33:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a182576926c2b560035db3d53abd614a1423145
Cr-Commit-Position: refs/heads/master@{#306307}

Powered by Google App Engine
This is Rietveld 408576698