Issue 766053007: Use source_set rather than static_library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 766053007: Use source_set rather than static_library (Closed)

Created:
6 years ago by abarth-chromium

Modified:
6 years ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Use source_set rather than static_library According to jamesr, static_library is almost never what we want because we just configure static libraries to be thin archives anyway. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/241999a0a60097136c2f4301254270e8f7026542

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sky/compositor/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/scheduler/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

6 years ago (2014-12-02 07:51:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
241999a0a60097136c2f4301254270e8f7026542 (presubmit successful).