Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 766023002: Rename 'instant' value of scroll-behavior CSS property to 'auto' (Closed)

Created:
6 years ago by ajuma
Modified:
6 years ago
Reviewers:
Ian Vollick
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rwlbuis
Project:
blink
Visibility:
Public.

Description

Rename 'instant' value of scroll-behavior CSS property to 'auto' This changes the 'instant' value of scroll-behavior to 'auto', matching a change made in the CSSOM View spec (and also matching Firefox's implementation). Spec: http://dev.w3.org/csswg/cssom-view/#css-properties BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -103 lines) Patch
M LayoutTests/fast/scroll-behavior/listbox-scrollTop.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollBy.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollLeft.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollTo.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollTop.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-hidden-scrollLeft.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-hidden-scrollTop.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scrollLeft.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/overflow-scroll-scrollTop.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/parse-scroll-behavior.html View 5 chunks +10 lines, -10 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/parse-scroll-behavior-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scroll.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollBy.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollLeft.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollTo.html View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollTop.html View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
ajuma
6 years ago (2014-11-28 20:55:37 UTC) #2
Ian Vollick
On 2014/11/28 20:55:37, ajuma wrote: This is very mechanical and lines up with the spec; ...
6 years ago (2014-11-28 21:02:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766023002/1
6 years ago (2014-11-28 21:10:45 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-28 22:06:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186196

Powered by Google App Engine
This is Rietveld 408576698