Clean up node iteration

test/cctest/compiler/test-node.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <functional>
 
 #include "src/v8.h"
 
 #include "graph-tester.h"
 #include "src/compiler/generic-node-inl.h"
@@ skipping 75 matching lines @@
   CHECK_EQ(1, n1->InputCount());
   CHECK_EQ(n0, *i);
   ++i;
   CHECK(n1->inputs().end() == i);
 }
 
 
 TEST(NodeUseIteratorEmpty) {
   GraphTester graph;
   Node* n1 = graph.NewNode(&dummy_operator);
-  Node::Uses::iterator i(n1->uses().begin());
   int use_count = 0;
-  for (; i != n1->uses().end(); ++i) {
-    Node::Edge edge(i.edge());
+  for (auto const edge : n1->use_edges()) {
     USE(edge);
     use_count++;
   }
   CHECK_EQ(0, use_count);
 }
 
 
 TEST(NodeUseIteratorOne) {
   GraphTester graph;
   Node* n0 = graph.NewNode(&dummy_operator);
@@ skipping 249 matching lines @@
 }
 
 
 TEST(AppendInputsAndIterator) {
   GraphTester graph;
 
   Node* n0 = graph.NewNode(&dummy_operator);
   Node* n1 = graph.NewNode(&dummy_operator, n0);
   Node* n2 = graph.NewNode(&dummy_operator, n0, n1);
 
-  Node::Inputs inputs(n2->inputs());
-  Node::Inputs::iterator current = inputs.begin();
+  auto inputs(n2->input_edges());
+  auto current = inputs.begin();
   CHECK(current != inputs.end());
-  CHECK(*current == n0);
+  CHECK((*current).to() == n0);
   ++current;
   CHECK(current != inputs.end());
-  CHECK(*current == n1);
+  CHECK((*current).to() == n1);
   ++current;
   CHECK(current == inputs.end());
 
   Node* n3 = graph.NewNode(&dummy_operator);
   n2->AppendInput(graph.zone(), n3);
-  inputs = n2->inputs();
+  inputs = n2->input_edges();
   current = inputs.begin();
   CHECK(current != inputs.end());
-  CHECK(*current == n0);
-  CHECK_EQ(0, current.index());
+  CHECK((*current).to() == n0);
+  CHECK_EQ(0, (*current).index());
   ++current;
   CHECK(current != inputs.end());
-  CHECK(*current == n1);
-  CHECK_EQ(1, current.index());
+  CHECK((*current).to() == n1);
+  CHECK_EQ(1, (*current).index());
   ++current;
   CHECK(current != inputs.end());
-  CHECK(*current == n3);
-  CHECK_EQ(2, current.index());
+  CHECK((*current).to() == n3);
+  CHECK_EQ(2, (*current).index());
   ++current;
   CHECK(current == inputs.end());
 }
 
 
 TEST(NullInputsSimple) {
   GraphTester graph;
 
   Node* n0 = graph.NewNode(&dummy_operator);
   Node* n1 = graph.NewNode(&dummy_operator, n0);
@@ skipping 428 matching lines @@
     n1->ReplaceInput(0, n1);  // self-reference.
 
     CHECK_EQ(0, n0->UseCount());
     CHECK_EQ(1, n1->UseCount());
     n1->RemoveAllInputs();
     CHECK_EQ(1, n1->InputCount());
     CHECK_EQ(0, n1->UseCount());
     CHECK_EQ(NULL, n1->InputAt(0));
   }
 }