Issue 765903002: Remove internals.setEnableMockPagePopup().

Issue 765903002: Remove internals.setEnableMockPagePopup(). (Closed)

Created:
6 years ago by tkent

Modified:
6 years ago

Reviewers:
keishi

CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, arv+blink, gavinp+loader_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Remove internals.setEnableMockPagePopup(). No one uses internals.setEnableMockPagePopup() any longer. We can remove it, MockPagePopup class, and PagePopupDriver interface. BUG=409503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186232

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -350 lines)			Patch
M	LayoutTests/fast/forms/resources/picker-common.js	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/loader/EmptyClients.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/page/ChromeClient.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
D	Source/core/page/PagePopupDriver.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download
M	Source/core/testing/Internals.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	5 chunks	+3 lines, -35 lines	0 comments	Download
M	Source/core/testing/Internals.idl	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/core/testing/MockPagePopupDriver.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	Source/core/testing/MockPagePopupDriver.cpp	View	1 chunk	+0 lines, -153 lines	0 comments	Download
M	Source/web/ChromeClientImpl.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/web/ChromeClientImpl.cpp	View	3 chunks	+4 lines, -14 lines	0 comments	Download
M	Source/web/WebViewImpl.h	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765903002/40001

6 years ago (2014-12-01 13:31:35 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-01 13:33:42 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186232