Issue 765883003: new api for adding indexed interceptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 765883003: new api for adding indexed interceptors (Closed)

Created:
6 years ago by dcarney

Modified:
6 years ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

new api for adding indexed interceptors R=svenpanne@chromium.org BUG=

Patch Set 2 : #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -67 lines)			Patch
M	include/v8.h	View		3 chunks	+32 lines, -2 lines	0 comments	Download
M	src/api.cc	View	1	2 chunks	+10 lines, -12 lines	0 comments	Download
M	test/cctest/test-api.cc	View		25 chunks	+54 lines, -47 lines	0 comments	Download
M	test/cctest/test-debug.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sven Panne

lgtm https://codereview.chromium.org/765883003/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/765883003/diff/1/src/api.cc#newcode1356 src/api.cc:1356: if (config.enumerator != 0) nit: braces

6 years ago (2014-12-05 14:31:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765883003/20001

6 years ago (2014-12-05 14:42:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 765883003: new api for adding indexed interceptors (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages