Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(125)

Issue 765813002: Ensure V8 snapshot files are included in official Chrome builds for Linux. (Closed)

Created:
6 years ago by baixo
Modified:
6 years ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure V8 snapshot files are included in official Chrome builds for Linux. BUG=421063, 437136 Committed: https://crrev.com/dd97f2b5ff8cbdab0bb9c0fec87d07f2fe2a3b50 Cr-Commit-Position: refs/heads/master@{#305990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/installer/linux/common/installer.include View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
baixo1
Please take a look.
6 years ago (2014-11-27 14:27:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-11-27 14:29:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765813002/1
6 years ago (2014-11-27 14:30:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/26993)
6 years ago (2014-11-27 14:35:03 UTC) #7
baixo1
phajdan: could you please take a look for owners? Thanks!
6 years ago (2014-11-27 15:06:11 UTC) #9
Paweł Hajdan Jr.
LGTM
6 years ago (2014-11-27 15:39:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765813002/1
6 years ago (2014-11-27 15:41:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-27 15:43:20 UTC) #13
commit-bot: I haz the power
6 years ago (2014-11-27 15:43:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd97f2b5ff8cbdab0bb9c0fec87d07f2fe2a3b50
Cr-Commit-Position: refs/heads/master@{#305990}

Powered by Google App Engine
This is Rietveld 408576698