Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: runtime/vm/raw_object.h

Issue 765743003: Support use of external strings as inputs to LoadCodeUnitsInstr. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: safety Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/regexp_assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index e83e01e13cd5cd1e01de2fd418e60a3691efdc20..5c0f9a93fe95fc1373ee2b6977cd7512a46e1081 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -1589,6 +1589,10 @@ class ExternalStringData {
return peer_;
}
+ static intptr_t data_offset() {
+ return OFFSET_OF(ExternalStringData<T>, data_);
+ }
+
private:
const T* data_;
void* peer_;
@@ -1598,16 +1602,22 @@ class ExternalStringData {
class RawExternalOneByteString : public RawString {
RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalOneByteString);
+ public:
+ typedef ExternalStringData<uint8_t> ExternalData;
- ExternalStringData<uint8_t>* external_data_;
+ private:
+ ExternalData* external_data_;
friend class Api;
};
class RawExternalTwoByteString : public RawString {
RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalTwoByteString);
+ public:
+ typedef ExternalStringData<uint16_t> ExternalData;
- ExternalStringData<uint16_t>* external_data_;
+ private:
+ ExternalData* external_data_;
friend class Api;
};
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/regexp_assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698