Support use of external strings as inputs to LoadCodeUnitsInstr.

runtime/vm/raw_object.h

Index: runtime/vm/raw_object.h
diff --git a/runtime/vm/raw_object.h b/runtime/vm/raw_object.h
index e83e01e13cd5cd1e01de2fd418e60a3691efdc20..f4a375c799dcd83459a6c1abf2253164add377c3 100644
--- a/runtime/vm/raw_object.h
+++ b/runtime/vm/raw_object.h
@@ -1589,6 +1589,10 @@ class ExternalStringData {
     return peer_;
   }
 
+  static intptr_t data_offset() {
+    return OFFSET_OF(ExternalStringData<T>, data_);
+  }
+
  private:
   const T* data_;
   void* peer_;
@@ -1598,16 +1602,28 @@ class ExternalStringData {
 
 class RawExternalOneByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalOneByteString);
+ public:
+  typedef ExternalStringData<uint8_t> ExternalData;
+  static intptr_t data_offset() {

[Vyacheslav Egorov (Google), 2014/11/27 14:27:43]

rename it to external_data_offset() and move the the ExternalOneByteString to
match all other RawXXX / XXX classes. It's always XXX class that has _offset
getter right now.

[zerny-google, 2014/12/01 15:33:30]

Done.

+    return OFFSET_OF(RawExternalOneByteString, external_data_);
+  }
 
-  ExternalStringData<uint8_t>* external_data_;
+ private:
+  ExternalData* external_data_;
   friend class Api;
 };
 
 
 class RawExternalTwoByteString : public RawString {
   RAW_HEAP_OBJECT_IMPLEMENTATION(ExternalTwoByteString);
+ public:
+  typedef ExternalStringData<uint16_t> ExternalData;
+  static intptr_t data_offset() {
+    return OFFSET_OF(RawExternalTwoByteString, external_data_);
+  }
 
-  ExternalStringData<uint16_t>* external_data_;
+ private:
+  ExternalData* external_data_;
   friend class Api;
 };