Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 765743002: Re-land: Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotif… (Closed)

Created:
6 years ago by Hannes Payer (out of office)
Modified:
6 years ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Re-land: Distinguish beween final incremental mark-compact and full mark-compact event in IdleNotification. BUG= R=ulan@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/5c3d1cbf7571e1814c8a3cb5d126228387f23740

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -38 lines) Patch
M src/heap/gc-idle-time-handler.h View 4 chunks +17 lines, -0 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 4 chunks +25 lines, -2 lines 0 comments Download
M src/heap/gc-tracer.h View 10 chunks +41 lines, -8 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 9 chunks +57 lines, -24 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Hannes Payer (out of office)
6 years ago (2014-11-27 10:49:10 UTC) #2
ulan
lgtm
6 years ago (2014-11-27 10:54:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765743002/20001
6 years ago (2014-11-27 10:58:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1364)
6 years ago (2014-11-27 11:22:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765743002/40001
6 years ago (2014-11-27 11:57:35 UTC) #9
commit-bot: I haz the power
CQ experienced an internal error when committing your CL and the maintainers were notified. Sorry ...
6 years ago (2014-11-27 12:24:59 UTC) #11
Hannes Payer (out of office)
6 years ago (2014-11-27 12:40:04 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
5c3d1cbf7571e1814c8a3cb5d126228387f23740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698