Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp - Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/tests/results/core/V8TestDictionary.cpp ('K') | « Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

diff --git a/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

index 5982e3377808d483a30f1cb06c097530ed091153..a36a1360ef433ca791d94fe96ad85d2af853a038 100644

--- a/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

+++ b/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

@@ -28,7 +28,7 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Hand

v8::Local<v8::Object> v8Object = v8Value->ToObject(isolate);

v8::TryCatch block;

v8::Local<v8::Value> derivedStringMemberValue = v8Object->Get(v8String(isolate, "derivedStringMember"));

- if (!derivedStringMemberValue.IsEmpty() && !isUndefinedOrNull(derivedStringMemberValue)) {

+ if (!derivedStringMemberValue.IsEmpty() && !derivedStringMemberValue->IsUndefined()) {

TOSTRING_VOID(V8StringResource<>, derivedStringMember, derivedStringMemberValue);

impl.setDerivedStringMember(derivedStringMember);

} else if (block.HasCaught()) {

@@ -37,7 +37,7 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Hand

}

v8::Local<v8::Value> derivedStringMemberWithDefaultValue = v8Object->Get(v8String(isolate, "derivedStringMemberWithDefault"));

- if (!derivedStringMemberWithDefaultValue.IsEmpty() && !isUndefinedOrNull(derivedStringMemberWithDefaultValue)) {

+ if (!derivedStringMemberWithDefaultValue.IsEmpty() && !derivedStringMemberWithDefaultValue->IsUndefined()) {

TOSTRING_VOID(V8StringResource<>, derivedStringMemberWithDefault, derivedStringMemberWithDefaultValue);

impl.setDerivedStringMemberWithDefault(derivedStringMemberWithDefault);

} else if (block.HasCaught()) {