Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h - Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/dictionary_v8.cpp ('K') | « Source/bindings/tests/results/core/TestDictionary.h ('k') | Source/bindings/tests/results/core/TestInterfaceEventInit.h » ('j') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

diff --git a/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h b/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

index 24031243d1b57061747f49c897606e97c99325dc..8d2b2900a1f160dd132000c5f527326fa4fd3884 100644

--- a/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

+++ b/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h

@@ -21,10 +21,12 @@ public:

bool hasDerivedStringMember() const { return !m_derivedStringMember.isNull(); }

String derivedStringMember() const { return m_derivedStringMember; }

void setDerivedStringMember(String value) { m_derivedStringMember = value; }

+ void resetDerivedStringMember() { m_derivedStringMember = String(); }

bool hasDerivedStringMemberWithDefault() const { return !m_derivedStringMemberWithDefault.isNull(); }

String derivedStringMemberWithDefault() const { return m_derivedStringMemberWithDefault; }

void setDerivedStringMemberWithDefault(String value) { m_derivedStringMemberWithDefault = value; }

+ void resetDerivedStringMemberWithDefault() { m_derivedStringMemberWithDefault = String(); }

virtual void trace(Visitor*);