IDL: Null values should be converted for non-nullable dictionary members

Source/bindings/scripts/v8_dictionary.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generate template contexts of dictionaries for both v8 bindings and
 implementation classes that are used by blink's core/modules.
 """
 
 import operator
 from idl_types import IdlType
@@ skipping 10 matching lines @@
 DICTIONARY_CPP_INCLUDES = frozenset([
     'bindings/core/v8/ExceptionState.h',
 ])
 
 
 def setter_name_for_dictionary_member(member):
     name = v8_utilities.cpp_name(member)
     return 'set%s' % v8_utilities.capitalize(name)
 
 
+def null_setter_name_for_dictionary_member(member):
+    if member.idl_type.is_nullable:
+        name = v8_utilities.cpp_name(member)
+        return 'set%sToNull' % v8_utilities.capitalize(name)
+    return None
+
+
 def has_method_name_for_dictionary_member(member):
     name = v8_utilities.cpp_name(member)
     return 'has%s' % v8_utilities.capitalize(name)
 
 
 def unwrap_nullable_if_needed(idl_type):
     if idl_type.is_nullable:
         return idl_type.inner_type
     return idl_type
 
@@ skipping 20 matching lines @@
         context.update({
             'parent_cpp_class': parent_cpp_class,
             'parent_v8_class': v8_types.v8_type(parent_cpp_class),
         })
     return context
 
 
 def member_context(member):
     idl_type = member.idl_type
     idl_type.add_includes_for_type()
-    idl_type = unwrap_nullable_if_needed(idl_type)
+    unwrapped_idl_type = unwrap_nullable_if_needed(idl_type)
 
     def default_values():
         if not member.default_value:
             return None, None
         if member.default_value.is_null:
             return None, 'v8::Null(isolate)'
         cpp_default_value = str(member.default_value)
-        v8_default_value = idl_type.cpp_value_to_v8_value(
+        v8_default_value = unwrapped_idl_type.cpp_value_to_v8_value(
             cpp_value=cpp_default_value, isolate='isolate',
             creation_context='creationContext')
         return cpp_default_value, v8_default_value
 
     cpp_default_value, v8_default_value = default_values()
     cpp_name = v8_utilities.cpp_name(member)
 
     return {
         'cpp_default_value': cpp_default_value,
         'cpp_name': cpp_name,
-        'cpp_type': idl_type.cpp_type,
-        'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(
+        'cpp_type': unwrapped_idl_type.cpp_type,
+        'cpp_value_to_v8_value': unwrapped_idl_type.cpp_value_to_v8_value(
             cpp_value='impl.%s()' % cpp_name, isolate='isolate',
             creation_context='creationContext',
             extended_attributes=member.extended_attributes),
-        'enum_validation_expression': idl_type.enum_validation_expression,
+        'enum_validation_expression': unwrapped_idl_type.enum_validation_expression,
         'has_method_name': has_method_name_for_dictionary_member(member),
-        'is_object': idl_type.name == 'Object',
+        'is_nullable': idl_type.is_nullable,
+        'is_object': unwrapped_idl_type.name == 'Object',
         'name': member.name,
         'setter_name': setter_name_for_dictionary_member(member),
-        'use_output_parameter_for_result': idl_type.use_output_parameter_for_result,
+        'null_setter_name': null_setter_name_for_dictionary_member(member),
+        'use_output_parameter_for_result': unwrapped_idl_type.use_output_parameter_for_result,
         'v8_default_value': v8_default_value,
-        'v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value(
+        'v8_value_to_local_cpp_value': unwrapped_idl_type.v8_value_to_local_cpp_value(
             member.extended_attributes, member.name + 'Value',
             member.name, isolate='isolate'),
     }
 
 
 # Context for implementation classes
 
 def dictionary_impl_context(dictionary, interfaces_info):
     includes.clear()
     header_includes = set(['platform/heap/Handle.h'])
@@ skipping 45 matching lines @@
     header_includes.update(idl_type.impl_includes_for_type(interfaces_info))
     return {
         'cpp_default_value': cpp_default_value,
         'cpp_name': cpp_name,
         'getter_expression': getter_expression(),
         'has_method_expression': has_method_expression(),
         'has_method_name': has_method_name_for_dictionary_member(member),
         'is_object': is_object,
         'is_traceable': idl_type.is_traceable,
         'member_cpp_type': member_cpp_type(),
+        'null_setter_name': null_setter_name_for_dictionary_member(member),
         'rvalue_cpp_type': idl_type.cpp_type_args(used_as_rvalue_type=True),
         'setter_name': setter_name_for_dictionary_member(member),
     }