LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html - Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html ('k') | LayoutTests/fast/dom/idl-dictionary-unittest.html » ('j') | Source/bindings/templates/dictionary_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Canvas Hit Regions: fillRule test</title>	4 <title>Canvas Hit Regions: fillRule test</title>

5 <script src="../../resources/js-test.js"></script>	5 <script src="../../resources/js-test.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <canvas id="canvas" width="400" height="400">	8 <canvas id="canvas" width="400" height="400">

9 </canvas>	9 </canvas>

10 <script>	10 <script>

(...skipping 59 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
70	70

71 debug("fillRule = nonzero:");	71 debug("fillRule = nonzero:");

72 shouldBe("clickCanvas(1, 1)", "'nonzero'");	72 shouldBe("clickCanvas(1, 1)", "'nonzero'");

73 shouldBe("clickCanvas(99, 98)", "'nonzero'");	73 shouldBe("clickCanvas(99, 98)", "'nonzero'");

74 shouldBe("clickCanvas(21, 21)", "'nonzero'");	74 shouldBe("clickCanvas(21, 21)", "'nonzero'");

75 shouldBe("clickCanvas(50, 50)", "'nonzero'");	75 shouldBe("clickCanvas(50, 50)", "'nonzero'");

76 debug("");	76 debug("");

77	77

78 context.removeHitRegion("nonzero");	78 context.removeHitRegion("nonzero");

79	79

	80 // FIXME: This test fails. ToString(null) becomes "null", and "null" is not a valid enum value of fillRule.

80 context.addHitRegion({	81 context.addHitRegion({

81 id : "nonzero",	82 id : "nonzero",

82 fillRule : null	83 fillRule : null

83 });	84 });

84	85

85 debug("fillRule = null, falls back to default (nonzero):");	86 debug("fillRule = null, falls back to default (nonzero):");

86 shouldBe("clickCanvas(1, 1)", "'nonzero'");	87 shouldBe("clickCanvas(1, 1)", "'nonzero'");

87 shouldBe("clickCanvas(99, 98)", "'nonzero'");	88 shouldBe("clickCanvas(99, 98)", "'nonzero'");

88 shouldBe("clickCanvas(21, 21)", "'nonzero'");	89 shouldBe("clickCanvas(21, 21)", "'nonzero'");

89 shouldBe("clickCanvas(50, 50)", "'nonzero'");	90 shouldBe("clickCanvas(50, 50)", "'nonzero'");

90 debug("");	91 debug("");

91	92

92 context.removeHitRegion("nonzero");	93 context.removeHitRegion("nonzero");

93	94

94 context.addHitRegion({	95 context.addHitRegion({

95 id : "nonzero",	96 id : "nonzero",

96 fillRule : undefined	97 fillRule : undefined

97 });	98 });

98	99

99 debug("fillRule = undefined, falls back to default (nonzero):");	100 debug("fillRule = undefined, falls back to default (nonzero):");

100 shouldBe("clickCanvas(1, 1)", "'nonzero'");	101 shouldBe("clickCanvas(1, 1)", "'nonzero'");

101 shouldBe("clickCanvas(99, 98)", "'nonzero'");	102 shouldBe("clickCanvas(99, 98)", "'nonzero'");

102 shouldBe("clickCanvas(21, 21)", "'nonzero'");	103 shouldBe("clickCanvas(21, 21)", "'nonzero'");

103 shouldBe("clickCanvas(50, 50)", "'nonzero'");	104 shouldBe("clickCanvas(50, 50)", "'nonzero'");

104 debug("");	105 debug("");

105	106

106 </script>	107 </script>

107 </body>	108 </body>

108 </html>	109 </html>

OLD	NEW