Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4114)

Unified Diff: Source/platform/heap/Heap.h

Issue 765673004: Oilpan: support eager tracing of objects when marking. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: For eager tracing, check for cross-heap access Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/Heap.h
diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h
index 791226349747b878b8b0e0560dfdf3c59cda9c88..ee136e71dbef5f492855bea518bd3ed914e61eb0 100644
--- a/Source/platform/heap/Heap.h
+++ b/Source/platform/heap/Heap.h
@@ -97,11 +97,6 @@ const uint8_t finalizedZapValue = 24;
const uint8_t orphanedZapValue = 240;
const int numberOfPagesToConsiderForCoalescing = 100;
-enum CallbackInvocationMode {
- GlobalMarking,
- ThreadLocalMarking,
-};
-
class CallbackStack;
class PageMemory;
template<ThreadAffinity affinity> class ThreadLocalPersistents;
@@ -887,7 +882,7 @@ public:
// Pop the top of a marking stack and call the callback with the visitor
// and the object. Returns false when there is nothing more to do.
- template<CallbackInvocationMode Mode> static bool popAndInvokeTraceCallback(CallbackStack*, Visitor*);
+ static bool popAndInvokeTraceCallback(CallbackStack*, Visitor*);
// Remove an item from the post-marking callback stack and call
// the callback with the visitor and the object pointer. Returns
@@ -914,7 +909,7 @@ public:
static void collectGarbage(ThreadState::StackState, ThreadState::CauseOfGC = ThreadState::NormalGC);
static void collectGarbageForTerminatingThread(ThreadState*);
static void collectAllGarbage();
- template<CallbackInvocationMode Mode> static void processMarkingStack();
+ static void processMarkingStack();
static void postMarkingProcessing();
static void globalWeakProcessing();
static void setForcePreciseGCForTesting();

Powered by Google App Engine
This is Rietveld 408576698