Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: Source/platform/heap/Heap.h

Issue 765673004: Oilpan: support eager tracing of objects when marking. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Tidying up Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/platform/heap/Heap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Heap.h
diff --git a/Source/platform/heap/Heap.h b/Source/platform/heap/Heap.h
index 87fbe5df1a193c6e350b22e43baf84dded5519ad..5a3a1cb3a2f1ef7657b5406bb88b51db11b9b001 100644
--- a/Source/platform/heap/Heap.h
+++ b/Source/platform/heap/Heap.h
@@ -97,11 +97,6 @@ const uint8_t finalizedZapValue = 24;
const uint8_t orphanedZapValue = 240;
const int numberOfPagesToConsiderForCoalescing = 100;
-enum CallbackInvocationMode {
- GlobalMarking,
- ThreadLocalMarking,
-};
-
class CallbackStack;
class PageMemory;
template<ThreadAffinity affinity> class ThreadLocalPersistents;
@@ -890,7 +885,7 @@ public:
// Pop the top of a marking stack and call the callback with the visitor
// and the object. Returns false when there is nothing more to do.
- template<CallbackInvocationMode Mode> static bool popAndInvokeTraceCallback(CallbackStack*, Visitor*);
+ static bool popAndInvokeTraceCallback(CallbackStack*, Visitor*);
// Remove an item from the post-marking callback stack and call
// the callback with the visitor and the object pointer. Returns
@@ -917,9 +912,10 @@ public:
static void collectGarbage(ThreadState::StackState, ThreadState::GCType = ThreadState::ForcedGC);
static void collectGarbageForTerminatingThread(ThreadState*);
static void collectAllGarbage();
- template<CallbackInvocationMode Mode> static void processMarkingStack();
- static void postMarkingProcessing();
- static void globalWeakProcessing();
+
+ static void processMarkingStack(Visitor*);
+ static void postMarkingProcessing(Visitor*);
+ static void globalWeakProcessing(Visitor*);
static void setForcePreciseGCForTesting();
static void preGC();
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/platform/heap/Heap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698