Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2593)

Unified Diff: media/cast/receiver/cast_receiver_impl.cc

Issue 765643006: Cast: Make receiver use cast_transport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix end2end test Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/receiver/cast_receiver_impl.cc
diff --git a/media/cast/receiver/cast_receiver_impl.cc b/media/cast/receiver/cast_receiver_impl.cc
index 8265211c71cd5d431fd61078bbf79b07e038d6bc..32b2c8c95c72637f733d60eabc7cba620e8af7fb 100644
--- a/media/cast/receiver/cast_receiver_impl.cc
+++ b/media/cast/receiver/cast_receiver_impl.cc
@@ -20,25 +20,19 @@ scoped_ptr<CastReceiver> CastReceiver::Create(
scoped_refptr<CastEnvironment> cast_environment,
const FrameReceiverConfig& audio_config,
const FrameReceiverConfig& video_config,
- PacketSender* const packet_sender) {
+ CastTransportSender* const transport) {
return scoped_ptr<CastReceiver>(new CastReceiverImpl(
- cast_environment, audio_config, video_config, packet_sender));
+ cast_environment, audio_config, video_config, transport));
}
CastReceiverImpl::CastReceiverImpl(
scoped_refptr<CastEnvironment> cast_environment,
const FrameReceiverConfig& audio_config,
const FrameReceiverConfig& video_config,
- PacketSender* const packet_sender)
+ CastTransportSender* const transport)
: cast_environment_(cast_environment),
- pacer_(kTargetBurstSize,
- kMaxBurstSize,
- cast_environment->Clock(),
- cast_environment->Logging(),
- packet_sender,
- cast_environment->GetTaskRunner(CastEnvironment::MAIN)),
- audio_receiver_(cast_environment, audio_config, AUDIO_EVENT, &pacer_),
- video_receiver_(cast_environment, video_config, VIDEO_EVENT, &pacer_),
+ audio_receiver_(cast_environment, audio_config, AUDIO_EVENT, transport),
+ video_receiver_(cast_environment, video_config, VIDEO_EVENT, transport),
ssrc_of_audio_sender_(audio_config.incoming_ssrc),
ssrc_of_video_sender_(video_config.incoming_ssrc),
num_audio_channels_(audio_config.channels),
@@ -48,14 +42,14 @@ CastReceiverImpl::CastReceiverImpl(
CastReceiverImpl::~CastReceiverImpl() {}
-void CastReceiverImpl::DispatchReceivedPacket(scoped_ptr<Packet> packet) {
+void CastReceiverImpl::ReceivePacket(scoped_ptr<Packet> packet) {
const uint8_t* const data = &packet->front();
const size_t length = packet->size();
uint32 ssrc_of_sender;
if (Rtcp::IsRtcpPacket(data, length)) {
ssrc_of_sender = Rtcp::GetSsrcOfSender(data, length);
- } else if (!FrameReceiver::ParseSenderSsrc(data, length, &ssrc_of_sender)) {
+ } else if (!RtpParser::ParseSsrc(data, length, &ssrc_of_sender)) {
VLOG(1) << "Invalid RTP packet.";
return;
}
@@ -78,14 +72,6 @@ void CastReceiverImpl::DispatchReceivedPacket(scoped_ptr<Packet> packet) {
base::Passed(&packet)));
}
-PacketReceiverCallback CastReceiverImpl::packet_receiver() {
- return base::Bind(&CastReceiverImpl::DispatchReceivedPacket,
- // TODO(miu): This code structure is dangerous, since the
- // callback could be stored and then invoked after
- // destruction of |this|.
- base::Unretained(this));
-}
-
void CastReceiverImpl::RequestDecodedAudioFrame(
const AudioFrameDecodedCallback& callback) {
DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::MAIN));

Powered by Google App Engine
This is Rietveld 408576698