Cast: Make receiver use cast_transport

media/cast/net/rtcp/rtcp_defines.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_RTCP_RTCP_DEFINES_H_
 #define MEDIA_CAST_RTCP_RTCP_DEFINES_H_
 
 #include <map>
 #include <set>
 
@@ skipping 91 matching lines @@
 
   // Only set for packet events.
   uint16 packet_id;
 };
 
 typedef base::Callback<void(const RtcpCastMessage&)> RtcpCastMessageCallback;
 typedef base::Callback<void(base::TimeDelta)> RtcpRttCallback;
 typedef
 base::Callback<void(const RtcpReceiverLogMessage&)> RtcpLogMessageCallback;
 
+
+struct RtpReceiverStatistics {
+  RtpReceiverStatistics();
+  uint8 fraction_lost;

[miu, 2014/12/04 04:18:54]

IMO, now's a good time to replace these data members with more appropriate data
types.  Meaning, we shouldn't force the whole implementation to know of the RTCP
wire format.

For example, fraction_lost takes a value from 0 to 255, but that's not intuitive
at all.  Should it be a float, or remain an int that contains a percentage
value?

Also, it would be nice if each of the members of this struct had a short comment
for documentation purposes.

[hubbe, 2014/12/05 23:57:20]

I'm just moving this struct, I'd prefer not to change it.
However, I'll add a TODO for documenting the members.

+  uint32 cumulative_lost;  // 24 bits valid.
+  uint32 extended_high_sequence_number;
+  uint32 jitter;
+};
+
+// These are intended to only be created using Rtcp::ConvertToNTPAndSave.
+struct RtcpTimeData {
+  uint32 ntp_seconds;
+  uint32 ntp_fraction;
+  base::TimeTicks t;

[miu, 2014/12/04 04:18:54]

naming: Can we do a little better than |t|, like |timestamp| or |report_time|?

[hubbe, 2014/12/05 23:57:20]

Done.

+};
+
+struct SendRtcpFromRtpReceiver_Params {
+  SendRtcpFromRtpReceiver_Params();
+  ~SendRtcpFromRtpReceiver_Params();
+  uint32 ssrc;
+  uint32 sender_ssrc;
+  RtcpTimeData time_data;
+  scoped_ptr<RtcpCastMessage> cast_message;
+  base::TimeDelta target_delay;
+  scoped_ptr<std::vector<std::pair<RtpTimestamp, RtcpEvent> > > rtcp_events;
+  scoped_ptr<RtpReceiverStatistics> rtp_receiver_statistics;
+};
+
+
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_RTCP_RTCP_DEFINES_H_