chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm - Issue 765643003: Remove dependency from infobars component to the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm

Issue 765643003: Remove dependency from infobars component to the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/infobars/infobar_gradient_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm b/chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm

index dd25e546333eb0491b9544cf4c28a2f1a25df0fc..c3183a12e7dca20fa7ba226069f4a6e9aabd587f 100644

--- a/chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm

+++ b/chrome/browser/ui/cocoa/infobars/infobar_cocoa.mm

@@ -6,14 +6,6 @@

#import "chrome/browser/ui/cocoa/infobars/infobar_controller.h"

-const int infobars::InfoBar::kSeparatorLineHeight = 1;

-const int infobars::InfoBar::kDefaultArrowTargetHeight = 11;

-const int infobars::InfoBar::kMaximumArrowTargetHeight = 24;

-const int infobars::InfoBar::kDefaultArrowTargetHalfWidth =

- kDefaultArrowTargetHeight;

-const int infobars::InfoBar::kMaximumArrowTargetHalfWidth = 14;

-const int infobars::InfoBar::kDefaultBarTargetHeight = 36;

InfoBarCocoa::InfoBarCocoa(scoped_ptr<infobars::InfoBarDelegate> delegate)

: infobars::InfoBar(delegate.Pass()),

weak_ptr_factory_(this) {