Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 765603002: Switch Windows over to BoringSSL from NSS. (Closed)

Created:
6 years ago by davidben
Modified:
6 years ago
Reviewers:
brettw, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch Windows over to BoringSSL from NSS. This is a much much larger change than the diff suggests. If it breaks something, please revert first and ask questions later. BUG=338884 Committed: https://crrev.com/deaca2e618f14a475045cefcbe03d18eb79aaff7 Cr-Commit-Position: refs/heads/master@{#306358}

Patch Set 1 #

Patch Set 2 : Fix 32-bit build (turns out the warnings we use are different) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M build/common.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +4 lines, -3 lines 0 comments Download
M net/ssl/openssl_platform_key_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
davidben
I won't land this until https://codereview.chromium.org/731673002/ clears the CQ and until after the holidays. But, ...
6 years ago (2014-11-26 22:46:12 UTC) #2
Ryan Sleevi
Looks broken?
6 years ago (2014-11-27 14:03:16 UTC) #3
davidben
On 2014/11/27 14:03:16, Ryan Sleevi wrote: > Looks broken? Yeah, one of the unit tests ...
6 years ago (2014-11-27 16:18:04 UTC) #4
brettw
gn lgtm
6 years ago (2014-11-30 18:09:16 UTC) #5
davidben
On 2014/11/27 16:18:04, David Benjamin wrote: > On 2014/11/27 14:03:16, Ryan Sleevi wrote: > > ...
6 years ago (2014-12-01 21:22:22 UTC) #6
davidben
On 2014/12/01 21:22:22, David Benjamin wrote: > On 2014/11/27 16:18:04, David Benjamin wrote: > > ...
6 years ago (2014-12-02 00:07:55 UTC) #7
Ryan Sleevi
lgtm
6 years ago (2014-12-02 09:48:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765603002/20001
6 years ago (2014-12-02 09:48:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-02 10:42:32 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/deaca2e618f14a475045cefcbe03d18eb79aaff7 Cr-Commit-Position: refs/heads/master@{#306358}
6 years ago (2014-12-02 10:43:35 UTC) #12
markusheintz_
6 years ago (2014-12-02 12:12:38 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/769223002/ by markusheintz@chromium.org.

The reason for reverting is: breaks gn build
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20GN&number....

Powered by Google App Engine
This is Rietveld 408576698