Migrate crash reporting settings only if owner.

Migrate crash reporting settings only if owner.
Writing the crash reporting setting when not the owner results in an infinite loop. Migrate the settings only if the logged in user is the owner.

R=mnissler@chromium.org,zelidrag@chromium.org,pastarmovj@chromium.org
BUG=chromium-os:19335
TEST=Ran browser_tests as a non-owner to confirm they're working.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97455

[Mattias Nissler (ping if slow), 2011-08-18 13:43:26]

A concern regarding thread usage.

http://codereview.chromium.org/7655041/diff/1/chrome/browser/chromeos/user_cr...
File chrome/browser/chromeos/user_cros_settings_provider.cc (right):

http://codereview.chromium.org/7655041/diff/1/chrome/browser/chromeos/user_cr...
chrome/browser/chromeos/user_cros_settings_provider.cc:66:
SignedSettingsHelper::Get()->StartStorePropertyOp(name, value, callback);
I don't think it's safe to call this from the file thread, there's DCHECK in the
SignedSettingsHelperImpl::AddOpContext(). There's also OwnershipStatusChecker,
which helps when you need to check the ownership status from a different thread.

[rkc, 2011-08-19 13:24:02]

Not using the OwnershipStatusChecker since it doesn't tell us if the current
user is the owner or not; instead posting a task to run the start store op on
the UI thread.

http://codereview.chromium.org/7655041/diff/1/chrome/browser/chromeos/user_cr...
File chrome/browser/chromeos/user_cros_settings_provider.cc (right):

http://codereview.chromium.org/7655041/diff/1/chrome/browser/chromeos/user_cr...
chrome/browser/chromeos/user_cros_settings_provider.cc:66:
SignedSettingsHelper::Get()->StartStorePropertyOp(name, value, callback);
On 2011/08/18 13:43:26, Mattias Nissler wrote:
> I don't think it's safe to call this from the file thread, there's DCHECK in
the
> SignedSettingsHelperImpl::AddOpContext(). There's also OwnershipStatusChecker,
> which helps when you need to check the ownership status from a different
thread.

Calling on the UI thread now.
Done.

[Mattias Nissler (ping if slow), 2011-08-19 13:46:10]

LGTM. In the long run I guess it would be nicer to introduce a reusable helper
for making this query from the UI thread, but then again all signed_settings
code is going to be rewritten relatively soon.

On 2011/08/19 13:24:02, Rahul Chaturvedi wrote:
> Not using the OwnershipStatusChecker since it doesn't tell us if the current
> user is the owner or not; instead posting a task to run the start store op on
> the UI thread.
> 
>
http://codereview.chromium.org/7655041/diff/1/chrome/browser/chromeos/user_cr...
> File chrome/browser/chromeos/user_cros_settings_provider.cc (right):
> 
>
http://codereview.chromium.org/7655041/diff/1/chrome/browser/chromeos/user_cr...
> chrome/browser/chromeos/user_cros_settings_provider.cc:66:
> SignedSettingsHelper::Get()->StartStorePropertyOp(name, value, callback);
> On 2011/08/18 13:43:26, Mattias Nissler wrote:
> > I don't think it's safe to call this from the file thread, there's DCHECK in
> the
> > SignedSettingsHelperImpl::AddOpContext(). There's also
OwnershipStatusChecker,
> > which helps when you need to check the ownership status from a different
> thread.
> 
> Calling on the UI thread now.
> Done.