Issue 7655003: Make chrome_browser_tests work with irt=0 again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7655003: Make chrome_browser_tests work with irt=0 again (Closed)

Created:
9 years, 4 months ago by Roland McGrath

Modified:
9 years, 4 months ago

Reviewers:
bsy, Nick Bray

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

Description

Make chrome_browser_tests work with irt=0 again Since the conversion to libsys_private for local tests, nothing at all can run without an IRT unless its link uses ${NONIRT_LIBS}, and uses ${PTHREAD_LIBS} in place of plain -lpthread. To restore irt=0 support for development testing, we need to parameterize things this way for the browser-based tests as well. BUG= none TEST= chrome_browser_tests irt=0 works locally R=bsy@google.com,ncbray@google.com Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=6447

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -22 lines)			Patch
M	SConstruct	View	1 chunk	+6 lines, -11 lines	1 comment	Download
M	tests/imc_shm_mmap/nacl.scons	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/inbrowser_crash_test/nacl.scons	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/manifest_file/nacl.scons	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/plugin_async_messaging/nacl.scons	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/ppapi_geturl/nacl.scons	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/srpc/nacl.scons	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/srpc_hw/nacl.scons	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bsy

9 years, 4 months ago (2011-08-16 22:01:15 UTC) #2

comment nit.  lgtm.

http://codereview.chromium.org/7655003/diff/1/SConstruct
File SConstruct (right):

http://codereview.chromium.org/7655003/diff/1/SConstruct#newcode2563
SConstruct:2563: # TODO(mseaborn): This will go away when we only support using
PPAPI
i think this comment is out of date.  we need this to test service runtime
interfaces that is used by the IRT, so even when we only support PPAPI with IRT,
this is still needed.

Expand Messages | Collapse Messages