Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: src/objects-inl.h

Issue 765473004: Fast-to-slow migration should wipe out in-object space if it exists in the object after migration. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5313 matching lines...) Expand 10 before | Expand all | Expand 10 after
5324 // it should never try to (otherwise, layout descriptor must be updated too). 5324 // it should never try to (otherwise, layout descriptor must be updated too).
5325 #ifdef DEBUG 5325 #ifdef DEBUG
5326 PropertyDetails details = desc->GetDetails(); 5326 PropertyDetails details = desc->GetDetails();
5327 CHECK(details.type() != FIELD || !details.representation().IsDouble()); 5327 CHECK(details.type() != FIELD || !details.representation().IsDouble());
5328 #endif 5328 #endif
5329 } 5329 }
5330 5330
5331 5331
5332 Object* Map::GetBackPointer() { 5332 Object* Map::GetBackPointer() {
5333 Object* object = READ_FIELD(this, kTransitionsOrBackPointerOffset); 5333 Object* object = READ_FIELD(this, kTransitionsOrBackPointerOffset);
5334 if (object->IsDescriptorArray()) { 5334 if (object->IsTransitionArray()) {
5335 return TransitionArray::cast(object)->back_pointer_storage(); 5335 return TransitionArray::cast(object)->back_pointer_storage();
5336 } else { 5336 } else {
5337 DCHECK(object->IsMap() || object->IsUndefined()); 5337 DCHECK(object->IsMap() || object->IsUndefined());
5338 return object; 5338 return object;
5339 } 5339 }
5340 } 5340 }
5341 5341
5342 5342
5343 bool Map::HasElementsTransition() { 5343 bool Map::HasElementsTransition() {
5344 return HasTransitionArray() && transitions()->HasElementsTransition(); 5344 return HasTransitionArray() && transitions()->HasElementsTransition();
(...skipping 2129 matching lines...) Expand 10 before | Expand all | Expand 10 after
7474 #undef READ_SHORT_FIELD 7474 #undef READ_SHORT_FIELD
7475 #undef WRITE_SHORT_FIELD 7475 #undef WRITE_SHORT_FIELD
7476 #undef READ_BYTE_FIELD 7476 #undef READ_BYTE_FIELD
7477 #undef WRITE_BYTE_FIELD 7477 #undef WRITE_BYTE_FIELD
7478 #undef NOBARRIER_READ_BYTE_FIELD 7478 #undef NOBARRIER_READ_BYTE_FIELD
7479 #undef NOBARRIER_WRITE_BYTE_FIELD 7479 #undef NOBARRIER_WRITE_BYTE_FIELD
7480 7480
7481 } } // namespace v8::internal 7481 } } // namespace v8::internal
7482 7482
7483 #endif // V8_OBJECTS_INL_H_ 7483 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-unboxed-doubles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698