Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 765473004: Fast-to-slow migration should wipe out in-object space if it exists in the object after migration. (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fast-to-slow migration should wipe out in-object space if it exists in the object after migration. BUG=chromium:436816 LOG=N

Patch Set 1 #

Patch Set 2 : Correct regression number #

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M src/objects.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
6 years ago (2014-11-26 18:08:46 UTC) #2
Igor Sheludko
Addressed comments
6 years ago (2014-11-26 22:12:51 UTC) #3
Toon Verwaest
lgtm
6 years ago (2014-11-27 09:41:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765473004/40001
6 years ago (2014-11-27 09:43:13 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-27 10:10:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698