public/platform/WebServiceWorkerProviderClient.h - Issue 765323002: ServiceWorker: Add support for .skipWaiting and controllerchange event(3/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerProviderClient.h

Issue 765323002: ServiceWorker: Add support for .skipWaiting and controllerchange event(3/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add new test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebServiceWorkerProviderClient.h

diff --git a/public/platform/WebServiceWorkerProviderClient.h b/public/platform/WebServiceWorkerProviderClient.h

index 4cf94e7e4778667a222d36301565a82d7da5e1fb..c4e0154abe9e426c264e4735aa0b484ac1882edb 100644

--- a/public/platform/WebServiceWorkerProviderClient.h

+++ b/public/platform/WebServiceWorkerProviderClient.h

@@ -47,8 +47,7 @@ class WebServiceWorkerProviderClient {

public:

virtual ~WebServiceWorkerProviderClient() { }

- // FIXME remove the default parameter value once the Chromium side CL landed.

- virtual void setController(WebServiceWorker*, bool shouldNotifyControllerChange = false) = 0;

+ virtual void setController(WebServiceWorker*, bool shouldNotifyControllerChange) = 0;

virtual void setReadyRegistration(WebServiceWorkerRegistration*) = 0;

virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) = 0;

« no previous file with comments | « LayoutTests/http/tests/serviceworker/skip-waiting-without-client.html ('k') | no next file » | no next file with comments »