Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 765203003: Move t.p.page_set_archive_info.PageSetArchiveInfo to t.wpr.archive_info.WprArchiveInfo. (Closed)

Created:
6 years ago by chrishenry
Modified:
6 years ago
Reviewers:
nednguyen, slamm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move t.p.page_set_archive_info.PageSetArchiveInfo to t.wpr.archive_info.WprArchiveInfo. BUG=439700 Committed: https://crrev.com/c06ac51276ceeeb9700723a1606e133c059bea0a Cr-Commit-Position: refs/heads/master@{#307540}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -466 lines) Patch
D tools/telemetry/telemetry/page/page_set_archive_info.py View 1 1 chunk +0 lines, -204 lines 0 comments Download
D tools/telemetry/telemetry/page/page_set_archive_info_unittest.py View 1 chunk +0 lines, -186 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/user_story/user_story_set.py View 3 chunks +4 lines, -5 lines 0 comments Download
A + tools/telemetry/telemetry/wpr/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/wpr/archive_info.py View 1 11 chunks +39 lines, -40 lines 0 comments Download
A + tools/telemetry/telemetry/wpr/archive_info_unittest.py View 11 chunks +26 lines, -25 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
chrishenry
6 years ago (2014-12-06 05:40:13 UTC) #4
nednguyen
https://codereview.chromium.org/765203003/diff/40001/tools/telemetry/telemetry/wpr/archive_info.py File tools/telemetry/telemetry/wpr/archive_info.py (right): https://codereview.chromium.org/765203003/diff/40001/tools/telemetry/telemetry/wpr/archive_info.py#newcode102 tools/telemetry/telemetry/wpr/archive_info.py:102: self._SetWprFileForUserStory(user_story.display_name, target_wpr_file) Do we have a check to make ...
6 years ago (2014-12-08 00:53:16 UTC) #5
nednguyen
6 years ago (2014-12-08 00:53:17 UTC) #6
chrishenry
On 2014/12/08 00:53:16, nednguyen wrote: > https://codereview.chromium.org/765203003/diff/40001/tools/telemetry/telemetry/wpr/archive_info.py > File tools/telemetry/telemetry/wpr/archive_info.py (right): > > https://codereview.chromium.org/765203003/diff/40001/tools/telemetry/telemetry/wpr/archive_info.py#newcode102 > ...
6 years ago (2014-12-08 19:47:32 UTC) #7
nednguyen
On 2014/12/08 19:47:32, chrishenry wrote: > On 2014/12/08 00:53:16, nednguyen wrote: > > > https://codereview.chromium.org/765203003/diff/40001/tools/telemetry/telemetry/wpr/archive_info.py ...
6 years ago (2014-12-08 20:08:05 UTC) #8
nednguyen
On 2014/12/08 20:08:05, nednguyen wrote: > On 2014/12/08 19:47:32, chrishenry wrote: > > On 2014/12/08 ...
6 years ago (2014-12-08 20:08:13 UTC) #9
slamm
lgtm
6 years ago (2014-12-09 19:19:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765203003/60001
6 years ago (2014-12-09 19:20:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years ago (2014-12-09 20:38:56 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-09 20:39:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c06ac51276ceeeb9700723a1606e133c059bea0a
Cr-Commit-Position: refs/heads/master@{#307540}

Powered by Google App Engine
This is Rietveld 408576698