Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 765203002: Remove PlatformMouseEvent::m_modifierFlags member. (Closed)

Created:
6 years ago by zino
Modified:
6 years ago
Reviewers:
haraken, Rick Byers
CC:
blink-reviews, tyoshino+watch_chromium.org, eae+blinkwatch, blink-reviews-events_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove PlatformMouseEvent::m_modifierFlags member. The modifierFlags is no longer used anywhere. BUG=none TEST=exsiting tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PlatformMouseEvent.h View 6 chunks +0 lines, -6 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
zino
Dear all, Could you please review this simple cleanup? This CL is derived from https://codereview.chromium.org/727593003/diff/240001/Source/platform/PlatformEvent.h#newcode84 ...
6 years ago (2014-11-30 04:13:03 UTC) #1
zino
Dear all, Could you please review this simple cleanup? This CL is derived from https://codereview.chromium.org/727593003/diff/240001/Source/platform/Platfor... ...
6 years ago (2014-11-30 04:13:43 UTC) #3
haraken
LGTM
6 years ago (2014-11-30 04:18:07 UTC) #4
zino
On 2014/11/30 04:18:07, haraken wrote: > LGTM Wow.. Thanks for your surprisingly rapid response. :)
6 years ago (2014-11-30 04:22:31 UTC) #5
Rick Byers
Oh wow, so this was already completely unused? I was thinking it was used for ...
6 years ago (2014-12-01 16:02:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765203002/1
6 years ago (2014-12-01 16:44:26 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-01 16:46:16 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186245

Powered by Google App Engine
This is Rietveld 408576698