LayoutTests/fast/css/getComputedStyle/getComputedStyle-exceptions.html - Issue 765123002: Sync the getComputedStyle() IDL with the spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/getComputedStyle/getComputedStyle-exceptions.html

Issue 765123002: Sync the getComputedStyle() IDL with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 [

	9 "getComputedStyle()",

	10 "getComputedStyle(document)",

	11 "getComputedStyle(null)",

	12 "getComputedStyle(undefined)",

	13 ].forEach(function(expr)
	arv (Not doing code reviews) 2014/12/01 14:20:09 I would skip the forEach here. shouldThrow("getCo I would skip the forEach here. shouldThrow("getComputedStyle()"); shouldThrow("getComputedStyle(document)"); shouldThrow("getComputedStyle(null)"); shouldThrow("getComputedStyle(undefined)"); is just as readable. philipj_slow 2014/12/01 20:48:53 Done. Show quoted text On 2014/12/01 14:20:09, arv wrote: > I would skip the forEach here. > > shouldThrow("getComputedStyle()"); > shouldThrow("getComputedStyle(document)"); > shouldThrow("getComputedStyle(null)"); > shouldThrow("getComputedStyle(undefined)"); > > is just as readable. Done.
	14 {

	15 shouldThrow(expr);

	16 });

	17 </script>

	18 </body>

	19 </html>

OLD	NEW