Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

components/password_manager/core/common/password_manager_ui.h

Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index b7adbb4a5c7f52d8a4076609a7d3c0da774732d0..0ba25157fe76ab7d35f23a0d595528bf37ddb2cc 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -42,6 +42,13 @@ enum State {
 
   // Credentials are pending, but we don't need to pop up a bubble.
   CREDENTIAL_REQUEST_STATE,
+
+  // Password manager failed to detect the form. Now we need to ask user
+  // if he wants to report the URL by showing "Allow to submit URL?" bubble.
+  ASK_SUBMIT_URL_AND_BUBBLE_STATE,

[vabr (Chromium), 2014/12/03 14:08:07]

The name is unclear ("submit URL and bubble"?).
What about ASK_USER_TO_REPORT_URL_STATE?

[melandory, 2014/12/04 10:33:47]

Done.

+
+  // We don't need to pop "Allow to submit URL?" bubble.
+  ASK_SUBMIT_URL_STATE

[vabr (Chromium), 2014/12/03 14:08:07]

I don't think the comment and the state name explain sufficiently the purpose.

Is the meaning "ask the user to report the URL on next navigation?"

If so, please be explicit in the state name (and comment). Something like
ASK_USER_TO_REPORT_URL_AFTER_NEXT_LOAD_STATE is long, but probably helpful.

[melandory, 2014/12/04 10:33:47]

Done. Also you after you comment I realize that with current solution of how I
prolong bubble life three states is better than two.

 };
 
 // The position of a password item in a list of credentials.
@@ -63,6 +70,8 @@ bool IsCredentialsState(State state);
 // interaction.
 bool IsAutomaticDisplayState(State state);
 
+bool IsAskSubmitURLState(State state);
+
 // Returns the state that the bubble should be in after the automatic display
 // occurs.
 State GetEndStateForAutomaticState(State state);