Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on master Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 085ade883d105a432e3fbbd5e473e58d97715ee1..ca209ef8a2339df8cc0abd6da39a050afe3cff40 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -45,7 +45,7 @@ class PasswordManagerClient {
// Return true if "Allow to collect URL?" should be shown.
// TODO(vabr): If http://crbug.com/437528 gets fixed, make this a const
// method.
- virtual bool ShouldAskUserToSubmitURL();
+ virtual bool ShouldAskUserToSubmitURL(const GURL& url);
// Return true if |form| should not be available for autofill.
virtual bool ShouldFilterAutofillResult(
@@ -63,7 +63,7 @@ class PasswordManagerClient {
// This should be called if the password manager encounters a problem on
// |url|. The implementation should show the "Allow to collect URL?" bubble
// and, if the user confirms, report the |url|.
- virtual void AskUserAndMaybeReportURL(const std::string& url) const;
+ virtual void AskUserAndMaybeReportURL(const GURL& url) const;
// Called when all autofill results have been computed. Client can use
// this signal to report statistics. Default implementation is a noop.

Powered by Google App Engine
This is Rietveld 408576698