components/password_manager/core/browser/password_manager.h - Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on master Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.h

diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h

index bf0fd639823b065e3ad5cfc81121f5efe63fc7b6..366dbb7053957719238b70dbc69c2c53bd23f0bd 100644

--- a/components/password_manager/core/browser/password_manager.h

+++ b/components/password_manager/core/browser/password_manager.h

@@ -127,7 +127,7 @@ class PasswordManager : public LoginModel {

// values of |failure| also sends logs to the internals page through |logger|,

// it |logger| is not NULL.

void RecordFailure(ProvisionalSaveFailure failure,

- const std::string& form_origin,

+ const GURL& form_origin,

BrowserSavePasswordProgressLogger* logger);

// Possibly set up FieldTrial for testing other possible usernames. This only