chrome/browser/password_manager/chrome_password_manager_client.h - Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | chrome/browser/password_manager/chrome_password_manager_client_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index 634d8e192f71f3f20b62557bccd11ace464926ee..49cd9668914cecfbd22f82026c333c3370ed2b77 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -43,12 +43,12 @@ class ChromePasswordManagerClient

// PasswordManagerClient implementation.

bool IsAutomaticPasswordSavingEnabled() const override;

bool IsPasswordManagerEnabledForCurrentPage() const override;

- bool ShouldAskUserToSubmitURL() override;

+ bool ShouldAskUserToSubmitURL(const GURL& url) override;

bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override;

std::string GetSyncUsername() const override;

bool IsSyncAccountCredential(const std::string& username,

const std::string& origin) const override;

- void AskUserAndMaybeReportURL(const std::string& url) const override;

+ void AskUserAndMaybeReportURL(const GURL& url) const override;

void AutofillResultsComputed() override;

bool PromptUserToSavePassword(

scoped_ptr<password_manager::PasswordFormManager> form_to_save) override;