Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/ui/browser_command_controller.h"
@@ skipping 74 matching lines @@
 #if !defined(OS_ANDROID)
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
   if (!browser)
     return;
   LocationBar* location_bar = browser->window()->GetLocationBar();
   DCHECK(location_bar);
   location_bar->UpdateManagePasswordsIconAndBubble();
 #endif
 }
 
+void ManagePasswordsUIController::OnAskToReportURL(const std::string& host) {
+  origin_ = GURL("http://" + host);

[vabr (Chromium), 2014/12/03 14:08:06]

Why do you assume that the scheme is HTTP? It could be HTTPS. It might be a
better idea to pass the whole URL in the argument.

[melandory, 2014/12/04 10:33:47]

I've added "http" in order to form proper GURL and later I do not care is it
http or https because I show only host to user, which doesn't contain any
schema.

I'll pass proper GURL from the beginning, so we can later use more data, like
full URL instead of host only.

Done.

+  state_ = password_manager::ui::ASK_SUBMIT_URL_AND_BUBBLE_STATE;
+  UpdateBubbleAndIconVisibility();
+}
+
 void ManagePasswordsUIController::OnPasswordSubmitted(
     scoped_ptr<PasswordFormManager> form_manager) {
   form_manager_ = form_manager.Pass();
   password_form_map_ = ConstifyMap(form_manager_->best_matches());
   origin_ = PendingPassword().origin;
   state_ = password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE;
   UpdateBubbleAndIconVisibility();
 }
 
 bool ManagePasswordsUIController::OnChooseCredentials(
@@ skipping 139 matching lines @@
     const content::FrameNavigateParams& params) {
   // Don't react to in-page (fragment) navigations.
   if (details.is_in_page)
     return;
 
   // Don't do anything if a navigation occurs before a user could reasonably
   // interact with the password bubble.
   if (timer_ && timer_->Elapsed() < base::TimeDelta::FromSeconds(1))
     return;
 
+  // This allows "Allow to collect URL?" bubble to leave 1 page longer.

[vabr (Chromium), 2014/12/03 14:08:06]

typo: leave -> live (?)
Also, "1 page longer" sounds strange (page is not a time unit). Maybe "outlive
the coming navigation"?

[melandory, 2014/12/04 10:33:46]

Done.

+  if (state_ == password_manager::ui::ASK_SUBMIT_URL_STATE) {
+    // TODO(melandory): Substitude this with proper solution using

[vabr (Chromium), 2014/12/03 14:08:06]

typo: Substitude -> Substitute
Also: proper solution -> a proper solution

[melandory, 2014/12/04 10:33:46]

Done. Also "setlocal spell spelllang=en_us" IS now in my .vimrc, sorry.

+    // provisional_save_manager.
+    state_ = password_manager::ui::ASK_SUBMIT_URL_AND_BUBBLE_STATE;
+    return;
+  }
+
   // Otherwise, reset the password manager and the timer.
   state_ = password_manager::ui::INACTIVE_STATE;
   UpdateBubbleAndIconVisibility();
   timer_.reset(new base::ElapsedTimer());
 }
 
 void ManagePasswordsUIController::WasHidden() {
 #if !defined(OS_ANDROID)
   chrome::CloseManagePasswordsBubble(web_contents());
 #endif
@@ skipping 45 matching lines @@
 bool ManagePasswordsUIController::PasswordPendingUserDecision() const {
   return password_manager::ui::IsPendingState(state_);
 }
 
 void ManagePasswordsUIController::WebContentsDestroyed() {
   password_manager::PasswordStore* password_store =
       GetPasswordStore(web_contents());
   if (password_store)
     password_store->RemoveObserver(this);
 }