Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/histogram_samples.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
@@ skipping 17 matching lines @@
   void SetUp() override {
     // Create the test UIController here so that it's bound to
     // |test_web_contents_| and therefore accessible to the model.
     new ManagePasswordsUIControllerMock(test_web_contents_.get());
 
     model_.reset(new ManagePasswordsBubbleModel(test_web_contents_.get()));
   }
 
   void TearDown() override { model_.reset(); }
 
+  void PretendNeedToAskUserToSubmitURL() {
+    model_->set_state(
+        password_manager::ui::ASK_USER_REPORT_URL_BEFORE_LOAD_STATE);
+    model_->OnBubbleShown(ManagePasswordsBubble::AUTOMATIC);
+    controller()->SetState(
+        password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE);
+  }
+
+  void PretendUserInteractedWithAllowToSubmitBubbleBeforeNavigation() {
+    // TODO(melandory) This method should be removed after solution where
+    // "Ask to collect URL?" doesn't appear before navigation is implemented

[vabr (Chromium), 2014/12/05 13:43:22]

nit: Full-stop missing at the end.

[melandory, 2014/12/05 14:22:56]

Done.

+    model_->OnBubbleShown(ManagePasswordsBubble::AUTOMATIC);
+    model_->set_state(
+        password_manager::ui::ASK_USER_REPORT_URL_AFTER_LOAD_STATE);
+    controller()->SetState(
+        password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE);
+  }
+
   void PretendPasswordWaiting() {
     model_->set_state(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE);
     model_->OnBubbleShown(ManagePasswordsBubble::AUTOMATIC);
     controller()->SetState(
         password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE);
   }
 
   void PretendCredentialsWaiting() {
     model_->set_state(password_manager::ui::CREDENTIAL_REQUEST_STATE);
     model_->OnBubbleShown(ManagePasswordsBubble::AUTOMATIC);
@@ skipping 205 matching lines @@
   EXPECT_FALSE(controller()->saved_password());
   EXPECT_FALSE(controller()->never_saved_password());
   EXPECT_TRUE(controller()->choose_credential());
 
   histogram_tester.ExpectUniqueSample(
       kUIDismissalReasonMetric,
       password_manager::metrics_util::CLICKED_NOPE,
       1);
 }
 
+TEST_F(ManagePasswordsBubbleModelTest, ClickCollectURL) {
+  base::HistogramTester histogram_tester;
+  PretendNeedToAskUserToSubmitURL();
+  model_->OnCollectURLClicked();
+  model_->OnBubbleHidden();
+  EXPECT_EQ(model_->dismissal_reason(),
+            password_manager::metrics_util::CLICKED_COLLECT_URL);
+  EXPECT_EQ(
+      password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,
+      model_->state());
+
+  histogram_tester.ExpectUniqueSample(
+      kUIDismissalReasonMetric,
+      password_manager::metrics_util::CLICKED_COLLECT_URL, 1);
+}
+
+TEST_F(ManagePasswordsBubbleModelTest, ClickDoNotCollectURL) {
+  base::HistogramTester histogram_tester;
+  PretendNeedToAskUserToSubmitURL();
+  model_->OnDoNotCollectURLClicked();
+  model_->OnBubbleHidden();
+  EXPECT_EQ(model_->dismissal_reason(),
+            password_manager::metrics_util::CLICKED_DO_NOT_COLLECT_URL);
+  EXPECT_EQ(
+      password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,
+      model_->state());
+
+  histogram_tester.ExpectUniqueSample(
+      kUIDismissalReasonMetric,
+      password_manager::metrics_util::CLICKED_DO_NOT_COLLECT_URL, 1);
+}
+
+TEST_F(ManagePasswordsBubbleModelTest,
+       CollectURLBubbleCloseWithoutInteraction) {
+  base::HistogramTester histogram_tester;
+  PretendNeedToAskUserToSubmitURL();
+  model_->OnBubbleHidden();
+  EXPECT_EQ(model_->dismissal_reason(),
+            password_manager::metrics_util::NO_DIRECT_INTERACTION);
+  EXPECT_EQ(
+      password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,
+      model_->state());
+  histogram_tester.ExpectUniqueSample(
+      kUIDismissalReasonMetric,
+      password_manager::metrics_util::NO_DIRECT_INTERACTION, 1);
+}
+
+TEST_F(ManagePasswordsBubbleModelTest, ClickCollectURLBeforeNavigation) {
+  // TODO(melandory) This test case should be removed after solution where
+  // "Ask to collect URL?" doesn't appear before navigation is implemented
+  base::HistogramTester histogram_tester;
+  PretendUserInteractedWithAllowToSubmitBubbleBeforeNavigation();
+  model_->OnCollectURLClicked();
+  model_->OnBubbleHidden();
+  EXPECT_EQ(model_->dismissal_reason(),
+            password_manager::metrics_util::CLICKED_COLLECT_URL);
+  EXPECT_EQ(
+      password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,
+      model_->state());
+
+  histogram_tester.ExpectUniqueSample(
+      kUIDismissalReasonMetric,
+      password_manager::metrics_util::CLICKED_COLLECT_URL, 1);
+}
+
+TEST_F(ManagePasswordsBubbleModelTest, ClickDoNotCollectURLBeforeNavigation) {
+  // TODO(melandory) This test case should be removed after solution where
+  // "Ask to collect URL?" doesn't appear before navigation is implemented
+  base::HistogramTester histogram_tester;
+  PretendUserInteractedWithAllowToSubmitBubbleBeforeNavigation();
+  model_->OnDoNotCollectURLClicked();
+  model_->OnBubbleHidden();
+  EXPECT_EQ(model_->dismissal_reason(),
+            password_manager::metrics_util::CLICKED_DO_NOT_COLLECT_URL);
+  EXPECT_EQ(
+      password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,
+      model_->state());
+
+  histogram_tester.ExpectUniqueSample(
+      kUIDismissalReasonMetric,
+      password_manager::metrics_util::CLICKED_DO_NOT_COLLECT_URL, 1);
+}
+
+TEST_F(ManagePasswordsBubbleModelTest,
+       CollectURLBubbleCloseWithoutInteractionBeforeNavigation) {
+  // TODO(melandory) This test case should be removed after solution where
+  // "Ask to collect URL?" doesn't appear before navigation is implemented
+  base::HistogramTester histogram_tester;
+  PretendUserInteractedWithAllowToSubmitBubbleBeforeNavigation();
+  model_->OnBubbleHidden();
+  EXPECT_EQ(model_->dismissal_reason(),
+            password_manager::metrics_util::NO_DIRECT_INTERACTION);
+  EXPECT_EQ(
+      password_manager::ui::ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,
+      model_->state());
+  histogram_tester.ExpectUniqueSample(
+      kUIDismissalReasonMetric,
+      password_manager::metrics_util::NO_DIRECT_INTERACTION, 1);
+}
+
 TEST_F(ManagePasswordsBubbleModelTest, DismissCredential) {
   base::HistogramTester histogram_tester;
   PretendCredentialsWaiting();
   EXPECT_FALSE(controller()->choose_credential());
   model_->OnBubbleHidden();
   EXPECT_EQ(model_->dismissal_reason(),
             password_manager::metrics_util::NO_DIRECT_INTERACTION);
   EXPECT_FALSE(controller()->saved_password());
   EXPECT_FALSE(controller()->never_saved_password());
   EXPECT_TRUE(controller()->choose_credential());
@@ skipping 12 matching lines @@
   model_->set_state(password_manager::ui::MANAGE_STATE);
   EXPECT_FALSE(password_manager::ui::IsPendingState(model_->state()));
   model_->set_state(password_manager::ui::BLACKLIST_STATE);
   EXPECT_FALSE(password_manager::ui::IsPendingState(model_->state()));
 
   model_->set_state(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE);
   EXPECT_TRUE(password_manager::ui::IsPendingState(model_->state()));
   model_->set_state(password_manager::ui::PENDING_PASSWORD_STATE);
   EXPECT_TRUE(password_manager::ui::IsPendingState(model_->state()));
 }