Windows-specific bits for loading V8's initial snapshot from external files.

Windows-specific bits for loading V8's initial snapshot from external files.

BUG=421063

[baixo1, 2014-12-01 14:43:06]

baixo@google.com changed reviewers:
+ baixo@google.com, gab@chromium.org, jochen@chromium.org, mmoss@chromium.org

[baixo1, 2014-12-01 14:43:07]

Adding OWNERS:

gab: chrome/installer

mmoss: win/FILES.cfg

jochen: gin/

Could you guys take a look, please?

Thanks!

[gab, 2014-12-01 16:02:24]

Do you need those .bin's to be dropped on actual Chrome installs? And if so
where (i.e. in the version directory?)?

[baixo1, 2014-12-01 16:12:21]

On 2014/12/01 16:02:24, gab wrote:
> Do you need those .bin's to be dropped on actual Chrome installs? And if so
> where (i.e. in the version directory?)?

Yes. V8 is now initialized from external files (the .bin's I added) and Chrome
will crash if such files are not present. This is already the way it works
on Android, Linux and Mac.

I need them alongside the exe.

[gab, 2014-12-01 16:20:15]

On 2014/12/01 16:12:21, baixo1 wrote:
> On 2014/12/01 16:02:24, gab wrote:
> > Do you need those .bin's to be dropped on actual Chrome installs? And if so
> > where (i.e. in the version directory?)?
> 
> Yes. V8 is now initialized from external files (the .bin's I added) and Chrome
> will crash if such files are not present. This is already the way it works
> on Android, Linux and Mac.
> 
> I need them alongside the exe.

Having them alongside the exe is VERY hard and problematic on Windows.

To allow for in-use updates we put everything but chrome.exe itself in the
version folder besides chrome.exe.

In order to land in the version folder you'll need to update chrome.release as
well as the google3 signing script IIRC (+grt@ who knows signing better than I).

Is there a specific reason you think you need to be besides chrome.exe itself?
We have many ways (manifests, etc.) to help keep everything, even load time
dependencies, in the version directory; but I need to fully understand your use
case before I can help you further.

[jochen (gone - plz use gerrit), 2014-12-02 10:27:06]

On 2014/12/01 at 16:20:15, gab wrote:
> On 2014/12/01 16:12:21, baixo1 wrote:
> > On 2014/12/01 16:02:24, gab wrote:
> > > Do you need those .bin's to be dropped on actual Chrome installs? And if
so
> > > where (i.e. in the version directory?)?
> > 
> > Yes. V8 is now initialized from external files (the .bin's I added) and
Chrome
> > will crash if such files are not present. This is already the way it works
> > on Android, Linux and Mac.
> > 
> > I need them alongside the exe.
> 
> Having them alongside the exe is VERY hard and problematic on Windows.
> 
> To allow for in-use updates we put everything but chrome.exe itself in the
version folder besides chrome.exe.
> 
> In order to land in the version folder you'll need to update chrome.release as
well as the google3 signing script IIRC (+grt@ who knows signing better than I).
> 
> Is there a specific reason you think you need to be besides chrome.exe itself?
We have many ways (manifests, etc.) to help keep everything, even load time
dependencies, in the version directory; but I need to fully understand your use
case before I can help you further.

where's the icudtl.dat file? It should probably be right next to it.

[baixo1, 2014-12-02 11:20:13]

On 2014/12/02 10:27:06, jochen (slow) wrote:
> On 2014/12/01 at 16:20:15, gab wrote:
> > On 2014/12/01 16:12:21, baixo1 wrote:
> > > On 2014/12/01 16:02:24, gab wrote:
> > > > Do you need those .bin's to be dropped on actual Chrome installs? And if
> so
> > > > where (i.e. in the version directory?)?
> > > 
> > > Yes. V8 is now initialized from external files (the .bin's I added) and
> Chrome
> > > will crash if such files are not present. This is already the way it works
> > > on Android, Linux and Mac.
> > > 
> > > I need them alongside the exe.
> > 
> > Having them alongside the exe is VERY hard and problematic on Windows.
> > 
> > To allow for in-use updates we put everything but chrome.exe itself in the
> version folder besides chrome.exe.
> > 
> > In order to land in the version folder you'll need to update chrome.release
as
> well as the google3 signing script IIRC (+grt@ who knows signing better than
I).
> > 
> > Is there a specific reason you think you need to be besides chrome.exe
itself?
> We have many ways (manifests, etc.) to help keep everything, even load time
> dependencies, in the version directory; but I need to fully understand your
use
> case before I can help you further.
> 
> where's the icudtl.dat file? It should probably be right next to it.

Yes, exactly. I thought it was alongside the exe, but it's actually
in the version folder.

[baixo1, 2014-12-04 15:18:25]

baixo@google.com changed reviewers:
+ baixo@chromium.org, rmcilroy@chromium.org
- baixo@google.com, mmoss@chromium.org

[rmcilroy, 2015-01-09 13:39:56]

On 2014/12/02 11:20:13, baixo1 wrote:
> On 2014/12/02 10:27:06, jochen (slow) wrote:
> > On 2014/12/01 at 16:20:15, gab wrote:
> > > On 2014/12/01 16:12:21, baixo1 wrote:
> > > > On 2014/12/01 16:02:24, gab wrote:
> > > > > Do you need those .bin's to be dropped on actual Chrome installs? And
if
> > so
> > > > > where (i.e. in the version directory?)?
> > > > 
> > > > Yes. V8 is now initialized from external files (the .bin's I added) and
> > Chrome
> > > > will crash if such files are not present. This is already the way it
works
> > > > on Android, Linux and Mac.
> > > > 
> > > > I need them alongside the exe.
> > > 
> > > Having them alongside the exe is VERY hard and problematic on Windows.
> > > 
> > > To allow for in-use updates we put everything but chrome.exe itself in the
> > version folder besides chrome.exe.
> > > 
> > > In order to land in the version folder you'll need to update
chrome.release
> as
> > well as the google3 signing script IIRC (+grt@ who knows signing better than
> I).
> > > 
> > > Is there a specific reason you think you need to be besides chrome.exe
> itself?
> > We have many ways (manifests, etc.) to help keep everything, even load time
> > dependencies, in the version directory; but I need to fully understand your
> use
> > case before I can help you further.
> > 
> > where's the icudtl.dat file? It should probably be right next to it.
> 
> Yes, exactly. I thought it was alongside the exe, but it's actually
> in the version folder.

Moving this to https://codereview.chromium.org/819203003/

[gab, 2015-01-12 19:19:14]

On 2015/01/09 13:39:56, rmcilroy wrote:
> On 2014/12/02 11:20:13, baixo1 wrote:
> > On 2014/12/02 10:27:06, jochen (slow) wrote:
> > > On 2014/12/01 at 16:20:15, gab wrote:
> > > > On 2014/12/01 16:12:21, baixo1 wrote:
> > > > > On 2014/12/01 16:02:24, gab wrote:
> > > > > > Do you need those .bin's to be dropped on actual Chrome installs?
And
> if
> > > so
> > > > > > where (i.e. in the version directory?)?
> > > > > 
> > > > > Yes. V8 is now initialized from external files (the .bin's I added)
and
> > > Chrome
> > > > > will crash if such files are not present. This is already the way it
> works
> > > > > on Android, Linux and Mac.
> > > > > 
> > > > > I need them alongside the exe.
> > > > 
> > > > Having them alongside the exe is VERY hard and problematic on Windows.
> > > > 
> > > > To allow for in-use updates we put everything but chrome.exe itself in
the
> > > version folder besides chrome.exe.
> > > > 
> > > > In order to land in the version folder you'll need to update
> chrome.release
> > as
> > > well as the google3 signing script IIRC (+grt@ who knows signing better
than
> > I).
> > > > 
> > > > Is there a specific reason you think you need to be besides chrome.exe
> > itself?
> > > We have many ways (manifests, etc.) to help keep everything, even load
time
> > > dependencies, in the version directory; but I need to fully understand
your
> > use
> > > case before I can help you further.
> > > 
> > > where's the icudtl.dat file? It should probably be right next to it.
> > 
> > Yes, exactly. I thought it was alongside the exe, but it's actually
> > in the version folder.
> 
> Moving this to https://codereview.chromium.org/819203003/

SG, closing this CL then.