Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: chrome/browser/ui/views/location_bar/star_view.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/star_view.h
diff --git a/chrome/browser/ui/views/location_bar/star_view.h b/chrome/browser/ui/views/location_bar/star_view.h
index 58f4f2e661a74a195f7086c2d9efaa51dce51cc5..1b0e63cbbf78be4b332949d0b7be0a0d461a352d 100644
--- a/chrome/browser/ui/views/location_bar/star_view.h
+++ b/chrome/browser/ui/views/location_bar/star_view.h
@@ -7,12 +7,13 @@
#include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
+class Browser;
class CommandUpdater;
// The star icon to show a bookmark bubble.
class StarView : public BubbleIconView {
public:
- explicit StarView(CommandUpdater* command_updater);
+ StarView(CommandUpdater* command_updater, Browser* browser);
~StarView() override;
// Toggles the star on or off.
@@ -22,8 +23,11 @@ class StarView : public BubbleIconView {
// BubbleIconView:
bool IsBubbleShowing() const override;
void OnExecuting(BubbleIconView::ExecuteSource execute_source) override;
+ void ExecuteCommand(ExecuteSource source) override;
private:
+ Browser* browser_;
+
DISALLOW_COPY_AND_ASSIGN(StarView);
};
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | chrome/browser/ui/views/location_bar/star_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698