chrome/browser/ui/browser_commands.h - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Side by Side Diff: chrome/browser/ui/browser_commands.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nit. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMANDS_H_	5 #ifndef CHROME_BROWSER_UI_BROWSER_COMMANDS_H_

6 #define CHROME_BROWSER_UI_BROWSER_COMMANDS_H_	6 #define CHROME_BROWSER_UI_BROWSER_COMMANDS_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "chrome/browser/devtools/devtools_toggle_action.h"	10 #include "chrome/browser/devtools/devtools_toggle_action.h"

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87 void MoveTabNext(Browser* browser);	87 void MoveTabNext(Browser* browser);

88 void MoveTabPrevious(Browser* browser);	88 void MoveTabPrevious(Browser* browser);

89 void SelectNumberedTab(Browser* browser, int index);	89 void SelectNumberedTab(Browser* browser, int index);

90 void SelectLastTab(Browser* browser);	90 void SelectLastTab(Browser* browser);

91 void DuplicateTab(Browser* browser);	91 void DuplicateTab(Browser* browser);

92 bool CanDuplicateTab(const Browser* browser);	92 bool CanDuplicateTab(const Browser* browser);

93 content::WebContents* DuplicateTabAt(Browser* browser, int index);	93 content::WebContents* DuplicateTabAt(Browser* browser, int index);

94 bool CanDuplicateTabAt(Browser* browser, int index);	94 bool CanDuplicateTabAt(Browser* browser, int index);

95 void ConvertPopupToTabbedBrowser(Browser* browser);	95 void ConvertPopupToTabbedBrowser(Browser* browser);

96 void Exit();	96 void Exit();

97 void BookmarkCurrentPage(Browser* browser);	97 void BookmarkCurrentPageIgnoringExtensionOverrides(Browser* browser);

	98 void BookmarkCurrentPageAllowingExtensionOverrides(Browser* browser);

98 bool CanBookmarkCurrentPage(const Browser* browser);	99 bool CanBookmarkCurrentPage(const Browser* browser);

99 void BookmarkAllTabs(Browser* browser);	100 void BookmarkAllTabs(Browser* browser);

100 bool CanBookmarkAllTabs(const Browser* browser);	101 bool CanBookmarkAllTabs(const Browser* browser);

101 void Translate(Browser* browser);	102 void Translate(Browser* browser);

102 void ManagePasswordsForPage(Browser* browser);	103 void ManagePasswordsForPage(Browser* browser);

103 #if defined(OS_WIN)	104 #if defined(OS_WIN)

104 void TogglePagePinnedToStartScreen(Browser* browser);	105 void TogglePagePinnedToStartScreen(Browser* browser);

105 #endif	106 #endif

106 void SavePage(Browser* browser);	107 void SavePage(Browser* browser);

107 bool CanSavePage(const Browser* browser);	108 bool CanSavePage(const Browser* browser);

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
166 void CreateApplicationShortcuts(Browser* browser);	167 void CreateApplicationShortcuts(Browser* browser);

167 void CreateBookmarkAppFromCurrentWebContents(Browser* browser);	168 void CreateBookmarkAppFromCurrentWebContents(Browser* browser);

168 bool CanCreateApplicationShortcuts(const Browser* browser);	169 bool CanCreateApplicationShortcuts(const Browser* browser);

169 bool CanCreateBookmarkApp(const Browser* browser);	170 bool CanCreateBookmarkApp(const Browser* browser);

170	171

171 void ConvertTabToAppWindow(Browser* browser, content::WebContents* contents);	172 void ConvertTabToAppWindow(Browser* browser, content::WebContents* contents);

172	173

173 } // namespace chrome	174 } // namespace chrome

174	175

175 #endif // CHROME_BROWSER_UI_BROWSER_COMMANDS_H_	176 #endif // CHROME_BROWSER_UI_BROWSER_COMMANDS_H_

OLD	NEW