Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 730 matching lines @@
   chrome::AttemptUserExit();
 }
 
 void BookmarkCurrentPage(Browser* browser) {
   DCHECK(!chrome::ShouldRemoveBookmarkThisPageUI(browser->profile()));
 
 #if defined(ENABLE_EXTENSIONS)
   const extensions::Extension* extension = NULL;
   extensions::Command command;
   extensions::CommandService::ExtensionCommandType command_type;
-  if (GetBookmarkOverrideCommand(browser->profile(),
-                                 &extension,
-                                 &command,
-                                 &command_type)) {
+
+  // Bookmark command override for extensions will not be considered when user
+  // selects bookmark icon for bookmarking a page by mouse.
+  if (GetBookmarkOverrideCommand(browser->profile(), &extension, &command,
+                                 &command_type) &&
+      !browser->command_controller()
+           ->command_updater()
+           ->get_bookmark_icon_selected()) {

[Finnur, 2014/12/03 10:49:17]

Mike Wittman implemented the Ctrl+D override for extensions, so I think he
should at least weigh in. My thinking is along the same lines as Peter's: This
function doesn't know which type of event triggered it, which is key to
determining whether to check the override or not.

There are a few scenarios I can see:

1) A bookmarking override extension is registered for Ctrl+D.
2) A non-overriding extension has registered for Ctrl+D.
3) No extension has Ctrl+D registered.

Then you have at least three ways the Star popup can be activated (all need to
work).

a) Press Ctrl+D.
b) Mouse click on the Star.
c) Shift+Alt+T, press Tab until Star has focus, press Space/Enter.

Basically, scenarios b) and c) should lead to lines 748-772 not being executed. 

For Ctrl+D keypresses, the Star popup should show up for scenario 3. For
scenarios 1) and 2), the extension should handle it as the extension chooses.

     switch (command_type) {
       case extensions::CommandService::NAMED:
         browser->window()->ExecuteExtensionCommand(extension, command);
         break;
       case extensions::CommandService::BROWSER_ACTION:
       case extensions::CommandService::PAGE_ACTION:
         // BookmarkCurrentPage is called through a user gesture, so it is safe
         // to grant the active tab permission.
         extensions::ExtensionActionAPI::Get(browser->profile())->
             ShowExtensionActionPopup(extension, browser, true);
@@ skipping 502 matching lines @@
                                           browser->host_desktop_type()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 #endif  // defined(ENABLE_EXTENSIONS)
 
 }  // namespace chrome