Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 765033003: Oilpan: Move MockActiveDOMObject to Oilpan's heap (Closed)

Created:
6 years ago by haraken
Modified:
6 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: Move MockActiveDOMObject to Oilpan's heap This migration is needed to move LifecycleObserver's hierarchy to Oilpan's heap. Given that MockActiveDOMObject is used only in tests, this CL enables Oilpan by default for MockActiveDOMObject. BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186376

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Source/core/dom/ActiveDOMObjectTest.cpp View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
6 years ago (2014-12-03 02:12:56 UTC) #2
haraken
https://codereview.chromium.org/765033003/diff/60001/Source/core/dom/ActiveDOMObjectTest.cpp File Source/core/dom/ActiveDOMObjectTest.cpp (right): https://codereview.chromium.org/765033003/diff/60001/Source/core/dom/ActiveDOMObjectTest.cpp#newcode42 Source/core/dom/ActiveDOMObjectTest.cpp:42: class MockActiveDOMObject final : public GarbageCollectedFinalized<MockActiveDOMObject>, public ActiveDOMObject { ...
6 years ago (2014-12-03 02:19:44 UTC) #4
tkent
lgtm https://codereview.chromium.org/765033003/diff/60001/Source/core/dom/ActiveDOMObjectTest.cpp File Source/core/dom/ActiveDOMObjectTest.cpp (right): https://codereview.chromium.org/765033003/diff/60001/Source/core/dom/ActiveDOMObjectTest.cpp#newcode42 Source/core/dom/ActiveDOMObjectTest.cpp:42: class MockActiveDOMObject final : public GarbageCollectedFinalized<MockActiveDOMObject>, public ActiveDOMObject ...
6 years ago (2014-12-03 03:22:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765033003/80001
6 years ago (2014-12-03 04:36:12 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-03 05:36:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186376

Powered by Google App Engine
This is Rietveld 408576698