Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 764863003: Revert of Refactor GuestViewContainer::AttachRequest to allow for other request types (Closed)

Created:
6 years ago by danakj
Modified:
6 years ago
Reviewers:
Fady Samuel, paulmeyer
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor GuestViewContainer::AttachRequest to allow for other request types (patchset #2 id:20001 of https://codereview.chromium.org/765843003/) Reason for revert: Bots appear to be complaining of static initializers. http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=55741 Original issue's description: > Refactor GuestViewContainer::AttachRequest to allow for other request types > > In a subsequent CL, DetachGuest will be introduced, to allow a GuestView to > detach itself from its container. This CL performs the necessary refactor to allow > for new operations to be easily introduced. > > This CL also makes BrowserPlugin IDs unique per process. This allows addressing attachment, and soon detachment, across JavaScript contexts. > > BUG=434226 > TBR=lazyboy@chromium.org > > Committed: https://crrev.com/d397750f3e2e53f414a4798c4e5039837a8c00ea > Cr-Commit-Position: refs/heads/master@{#306025} TBR=paulmeyer@chromium.org,fsamuel@chromium.org NOTREECHECKS=true NOTRY=true BUG=434226 Committed: https://crrev.com/73232ae23928136c158b86ae5108f173f46c06d0 Cr-Commit-Position: refs/heads/master@{#306044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -175 lines) Patch
M content/renderer/browser_plugin/browser_plugin_manager.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.cc View 2 chunks +1 line, -4 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.h View 3 chunks +31 lines, -39 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 3 chunks +115 lines, -124 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
Created Revert of Refactor GuestViewContainer::AttachRequest to allow for other request types
6 years ago (2014-11-28 03:31:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764863003/1
6 years ago (2014-11-28 03:32:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-28 03:32:20 UTC) #3
commit-bot: I haz the power
6 years ago (2014-11-28 03:33:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73232ae23928136c158b86ae5108f173f46c06d0
Cr-Commit-Position: refs/heads/master@{#306044}

Powered by Google App Engine
This is Rietveld 408576698